Code completion fails after existing values in method arguments #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug in code completion where subsequent instance field and method suggestions were missing due to incorrect element collection prior to the caret position. Key changes include filtering out argument-parameter child elements during completion, new test files covering method parameter use cases, and refactoring of PSI element helper methods to support the updated logic.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| completePropertyAfterStaticPropertyCallWithMethodParameter.sql | Adds test case to verify completion after a static property call with a method parameter. |
| completeParameterFirstPropertyWithMethodParameter.sql | Introduces a test for parameter-first property completion using a method parameter. |
| completeInstancePropertyWithMethodParameter.sql | Adds a test verifying instance property completion with a method parameter. |
| completeDirectiveInsideForWithMethodParameter.sql | Enhances directive completion tests for for-loop constructs with method parameters. |
| completeDirectiveFieldInsideIfWithMethodParameter.sql | Adds tests to check directive completion inside if conditions with method parameters. |
| ProjectDetail.java | Introduces a new static method getProject(String) to retrieve a project from a subProjects list. |
| SqlCompleteTestDao.java | Declares new DAO methods to support the updated code completion scenarios. |
| SqlCompleteTest.kt | Updates test harness to include newly added SQL test files and validates various completion scenarios. |
| PsiElementExtension.kt | Removes an outdated helper function and adds a new utility for symbol identification. |
| SqlParameterCompletionProvider.kt | Refactors completion provider to remove legacy helper usage and introduce a new findSelfBlocks helper. |
...n/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt
Show resolved
Hide resolved
… are already specified.
xterao
force-pushed
the
fix/code-completion-fails
branch
from
193cede to
fe4d8c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking a method on a field-access element that already has a different variable name set in its argument parameter, subsequent suggestions for instance fields and methods were not shown.
The issue occurred because, when collecting the list of elements before the caret, children of the argument-parameter element were incorrectly treated as part of the field-access chain, resulting in an invalid property-access structure.
This update filters out any elements whose parent is the argument-parameter class when gathering preceding elements, so that only the correct elements are retrieved for suggestions.